Skip site navigation (1) Skip section navigation (2)

Re: COPY-able sql log outputs

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: FAST PostgreSQL <fastpgs(at)fast(dot)fujitsu(dot)com(dot)au>, pgsql-patches(at)postgresql(dot)org
Subject: Re: COPY-able sql log outputs
Date: 2007-03-31 15:55:45
Message-ID: 460E8481.3070707@hagander.net (view raw or flat)
Thread:
Lists: pgsql-patches
Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Then, it may be just me, but I find code like this:
>> ! 		sqllogFile = fopen(strcat(filename, ".sql"), "a");
>> very hard to read.
> 
> Such coding should be rejected out of hand anyway --- can you say
> "buffer overrun"?

I was thinking that, but given that it only takes the config parameter
from postgresql.conf and no actual user input, I considered it less
important. But thinking twice, yeah, even in that case it shouldn't be
done, just to stay on the safe side.

//Magnus

In response to

pgsql-patches by date

Next:From: Pavan DeolaseeDate: 2007-03-31 16:22:23
Subject: Re: CIC and deadlocks
Previous:From: Tom LaneDate: 2007-03-31 15:51:20
Subject: Re: COPY-able sql log outputs

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group