Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Then, it may be just me, but I find code like this:
>> ! sqllogFile = fopen(strcat(filename, ".sql"), "a");
>> very hard to read.
> Such coding should be rejected out of hand anyway --- can you say
> "buffer overrun"?
I was thinking that, but given that it only takes the config parameter
from postgresql.conf and no actual user input, I considered it less
important. But thinking twice, yeah, even in that case it shouldn't be
done, just to stay on the safe side.
In response to
pgsql-patches by date
|Next:||From: Pavan Deolasee||Date: 2007-03-31 16:22:23|
|Subject: Re: CIC and deadlocks|
|Previous:||From: Tom Lane||Date: 2007-03-31 15:51:20|
|Subject: Re: COPY-able sql log outputs |