Skip site navigation (1) Skip section navigation (2)

Re: [pgsql-patches] O_DIRECT support for Windows

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [pgsql-patches] O_DIRECT support for Windows
Date: 2007-03-27 20:38:40
Message-ID: 460980D0.6070703@hagander.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
IIRC, we're still waiting for performance numbers showing there exists a
win from this patch.

//Magnus

Bruce Momjian wrote:
> Magnus, where are on this?
> 
> ---------------------------------------------------------------------------
> 
> Magnus Hagander wrote:
>> We're ok with the alignment issues provided the is code added to reject
>> O_DIRECT if the sector size is too large.
>>
>> We also said we need to see some performance numbers on the effect of
>> the patch before it goes in.
>>
>> //Magnus
>>
>>
>> Bruce Momjian wrote:
>>> So, do we want this patch?  Are we OK on WIN32 alignment issues?
>>>
>>> ---------------------------------------------------------------------------
>>>
>>> ITAGAKI Takahiro wrote:
>>>> The attached is a patch to define O_DIRECT by ourselves on Windows,
>>>> and to map O_DIRECT to FILE_FLAG_NO_BUFFERING.
>>>>
>>>> There will be a consistency in our support between Windows and other OSes
>>>> that have O_DIRECT. Also, there is the following comment that says, I read,
>>>> we should do so.
>>>> | handle other flags? (eg FILE_FLAG_NO_BUFFERING/FILE_FLAG_WRITE_THROUGH)
>>>>
>>>> Is this worth doing? Do we need more performance reports for the change?
>>>>
>>>> Regards,
>>>> ---
>>>> ITAGAKI Takahiro
>>>> NTT Open Source Software Center
>>> [ Attachment, skipping... ]
>>>
>>>> ---------------------------(end of broadcast)---------------------------
>>>> TIP 2: Don't 'kill -9' the postmaster
>>
>> ---------------------------(end of broadcast)---------------------------
>> TIP 7: You can help support the PostgreSQL project by donating at
>>
>>                 http://www.postgresql.org/about/donate
> 


In response to

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2007-03-27 21:04:39
Subject: Re: Arrays of Complex Types
Previous:From: Simon RiggsDate: 2007-03-27 20:24:10
Subject: Re: Priorities for users or queries?

pgsql-patches by date

Next:From: Alvaro HerreraDate: 2007-03-27 20:58:16
Subject: autovacuum: recheck logic
Previous:From: Marko KreenDate: 2007-03-27 20:33:22
Subject: Re: DEALLOCATE ALL

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group