Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Reduce risk of accidentally running temp-install regression tests

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Peter Eisentraut <petere(at)postgresql(dot)org>, Michael Meskes <meskes(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Reduce risk of accidentally running temp-install regression tests
Date: 2008-11-28 23:54:15
Message-ID: 4606.1227916455@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Peter Eisentraut wrote:
>> Log Message:
>> -----------
>> Reduce risk of accidentally running temp-install regression tests against
>> a mismatching installation.

> This has apparently broken the ECPG tests - see buildfarm where multiple 
> members are red.

Yes, ecpg is still using the temp-port parameter that Peter removed :-(.

I have temporarily turned things green again (I think) by making ecpg
use --port instead, which is the new spelling of --temp-port.  However,
this is not really satisfactory because it negates the whole point of
Peter's patch, namely to have a less brittle way of selecting the
temp port.  But it looks like the temp port number is actually wired
into some of the ecpg tests' expected results, and so getting rid of it
is not as easy as one could wish.

Michael, could you look at removing that dependency so we can let
pg_regress.c select the port number as it wishes?  If it's not practical
to suppress the port number in the regression test output, maybe things
could be changed so that pg_regress.c itself substitutes in the port
number it's chosen.

			regards, tom lane

In response to

Responses

pgsql-committers by date

Next:From: Tom LaneDate: 2008-11-29 00:13:22
Subject: pgsql: Make sure we give an appropriate user-facing error when
Previous:From: Tom LaneDate: 2008-11-28 23:47:52
Subject: pgsql: Partial fix for fallout from temp-port changes.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group