Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Date: 2010-12-11 17:46:23
Message-ID: 4602.1292089583@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Sat, Dec 11, 2010 at 17:55, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> 1. How did all those pre-existing references to S_IRXWU compile?

> Yeah, that's weird. IIRC (I stopped looking for the moment, need a
> step back) some of them were protected by #ifndef WIN32, but not all
> of them..

The lightbulb just went on: in win32.h,

#define mkdir(a,b)	mkdir(a)

I didn't go through in complete detail, but I'll bet all the "working"
instances are in mkdir calls, or else inside #ifndef WIN32.

I think we can just #define the other cases as zeroes.  I'm not sure why
you think that's an issue for open --- the privileges don't exist.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2010-12-11 17:55:43
Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Previous:From: Tom LaneDate: 2010-12-11 17:13:24
Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags

pgsql-committers by date

Next:From: Magnus HaganderDate: 2010-12-11 17:55:43
Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags
Previous:From: Tom LaneDate: 2010-12-11 17:13:24
Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants for file permission flags

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group