Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Patches for pg_dumpall, complete-bundle.sh and dmg creation

From: Dave Page <dpage(at)postgresql(dot)org>
To: "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Patches for pg_dumpall, complete-bundle.sh and dmg creation
Date: 2007-02-16 09:43:02
Message-ID: 45D57CA6.4020708@postgresql.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
Florian G. Pflug wrote:
> Hi
> 
> Here are various small patches I created today.
> 
> 1) The first
> (pgadmin3-dumpall.patch) adds pg_dumpall to the list
> of postgres binaries that are copied into the app bundle.

Thanks, applied.

> 2) When testing that one, I noticed that complete-bundle.sh seems
> to be broken - at lost on my 10.3.9 buildserver. The reason is
> that awk is called with "-F: -F\ " - which I guess ist meant to
> mean "treat either a color or a space as field seperator". It
> seems, however, that the second -F just overrides that first,
> and therefore the filename followed by a colon is put into todo_obj,
> instead of just the filename. Since -F takes a regex as parameter,
> the fix is easy - just use ":| " as parameter to -F. While I was
> at it, I also changed the output record seperator from newline (default)
> to space. This is purely cosemtic, but makes the output of the script
> a bit more readable. This patch should probably be applied to head and
> 1.6.

Done. Seems to work fine here.

> 
> 3) The last patch ist a first shot at a create-dmg script. It seems to work
> quite fine - it even attaches a license to the dmg that the user has to
> accept before the dmg is mounted ;-)

Cool - works a treat here so I've replaced the installer with it in 
-head. It'd be really cool if you could work up one of those funky 
background graphics for the finder window that hint on how to install 
into the Applications dir. Hint, hint :-)

Thanks for the patches :-)

Regards, Dave.

In response to

Responses

pgadmin-hackers by date

Next:From: Florian G. PflugDate: 2007-02-16 11:07:39
Subject: Re: [PATCH] Patches for pg_dumpall, complete-bundle.sh and dmg creation
Previous:From: svnDate: 2007-02-16 09:13:00
Subject: SVN Commit by dpage: r5924 - in trunk/pgadmin3: . pkg/mac

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group