Skip site navigation (1) Skip section navigation (2)

[PATCH] Patches for pg_dumpall, complete-bundle.sh and dmg creation

From: "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [PATCH] Patches for pg_dumpall, complete-bundle.sh and dmg creation
Date: 2007-02-16 02:46:26
Message-ID: 45D51B02.3090907@phlo.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
Hi

Here are various small patches I created today.

1) The first
(pgadmin3-dumpall.patch) adds pg_dumpall to the list
of postgres binaries that are copied into the app bundle.

2) When testing that one, I noticed that complete-bundle.sh seems
to be broken - at lost on my 10.3.9 buildserver. The reason is
that awk is called with "-F: -F\ " - which I guess ist meant to
mean "treat either a color or a space as field seperator". It
seems, however, that the second -F just overrides that first,
and therefore the filename followed by a colon is put into todo_obj,
instead of just the filename. Since -F takes a regex as parameter,
the fix is easy - just use ":| " as parameter to -F. While I was
at it, I also changed the output record seperator from newline (default)
to space. This is purely cosemtic, but makes the output of the script
a bit more readable. This patch should probably be applied to head and
1.6.

Either awk behaves differently on 10.3 and 10.4, or complete-bundle.sh
has been broken for a while :-(. The reason that apparently nobody noticed
is probably that
a) Things always work in the machine the binary way compiled on, because 
there absolute references to the library are ok, meaning that a developer
probably won't recognize that there is a problem
b) The official pgadmin3 binaries are linked statically against wx and
libpq.

Since pg_dump, pg_restore (and now pg_dumpall) are probably _not_ linked
statically, breakage still occurs if complete-bundle.sh doesn't work 
correctly - but you'd only notice if you try backing up a database with 
pgadmin3.

3) The last patch ist a first shot at a create-dmg script. It seems to work
quite fine - it even attaches a license to the dmg that the user has to
accept before the dmg is mounted ;-)

greetings, Florian Pflug


Attachment: pgadmin3-dumpall.patch
Description: text/plain (708 bytes)
Attachment: pgadmin3-bundlefix.patch
Description: text/plain (492 bytes)
Attachment: pgadmin3-createdmg.patch
Description: text/plain (9.5 KB)

Responses

pgadmin-hackers by date

Next:From: svnDate: 2007-02-16 06:30:37
Subject: SVN Commit by guillaume: r5918 - branches/REL-1_6_0_PATCHES/pgadmin3/i18n/zh_TW
Previous:From: Dave PageDate: 2007-02-14 21:12:07
Subject: Re: SVN Commit by dpage: r5916 - in trunk/pgadmin 3:. pgadmin pgadmin/frm pgadmin/include/frm pgadmin/include/schema pgadmin/u ipkg/win32/src

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group