| From: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Joe Conway <mail(at)joeconway(dot)com>, "Hackers (PostgreSQL)" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: crash on 8.2 and cvshead - failed to add item to the |
| Date: | 2007-01-31 10:46:37 |
| Message-ID: | 45C0738D.10204@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Are you still concerned about the PageGetFreeSpace issue?
Not anymore.
The failure case I had in mind was not being able to find any valid
split points when a page is full of max-sized index tuples. On a closer
look, that doesn't seem to be a problem. Even though checksplitloc would
incorrectly consider the split (HIKEY+item)-(HIKEY+item+item) as
invalid, the split (HIKEY+item+item)-(HIKEY+item) is just as good.
Similarly on the rightmost page, even if (HIKEY+item)-(item+item+item)
is incorrectly considered as invalid, (HIKEY+item+item)-(item+item) is fine.
There also seems to always be some slack space because of alignments.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavan Deolasee | 2007-01-31 11:19:36 | Re: stack usage in toast_insert_or_update() |
| Previous Message | Magnus Hagander | 2007-01-31 09:58:59 | Re: [BUGS] Missing error message on missing ssl-key-files |