From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Jim Nasby <decibel(at)decibel(dot)org> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: BUG #2917: spi_prepare doesn't accept typename aliases |
Date: | 2007-01-26 23:11:45 |
Message-ID: | 45BA8AB1.6040005@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Jim Nasby wrote:
> On Jan 26, 2007, at 9:31 AM, Tom Lane wrote:
>> If you wanted to be a bit more ambitious maybe you could change the fact
>> that this code is throwing away typmod, which means that declarations
>> like "varchar(32)" would fail to work as expected. Perhaps it should be
>> fixed to save the typmods alongside the typioparams and then pass them
>> to InputFunctionCall instead of passing -1. On the other hand, we don't
>> currently enforce typmod for any function input or result arguments, so
>> maybe it's consistent that spi_prepare arguments ignore typmods too.
>> Thoughts?
>
> I'd like to see us move towards supporting that; both for function
> parameters/results as well as inside functions. It'd be nice if both
> cases got fixed at once, but IMHO fixing only one now would be better
> than fixing none.
>
I'm not going to do either in fixing this bug - I think they should be
fixed but are a separate issue. These probably belong on the TODO list.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2007-01-26 23:32:21 | How does EXEC_BACKEND process signals? |
Previous Message | Henry B. Hotz | 2007-01-26 23:11:27 | Re: 10 weeks to feature freeze (Pending Work) |