Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] BUG #2907: pg_get_serial_sequence quoting

From: Adriaan van Os <adriaan(at)microbizz(dot)nl>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: [HACKERS] BUG #2907: pg_get_serial_sequence quoting
Date: 2007-01-22 09:19:25
Message-ID: 45B4819D.7040308@microbizz.nl (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackerspgsql-patches
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
>>> I presume the reason for that is that the first paramater can be
>>> qualified:
>>> select pg_get_serial_sequence('"public"."FOO"', 'Ff1');
> 
>> Would someone explain why qualification makes us lowercase the first
>> parameter by default?  I don't understand it well enough to document it.
> 
> The point is that we have to parse the first parameter, whereas the
> second one can be taken literally.

It still looks inconsistent and ugly. I think the design mistake of pg_get_serial_sequence is that 
it takes two parameters rather than one (a fully qualified doublequoted columnname path) or three 
(optionally empty schema, tablename, columnname, all three literal).

Regards,

Adriaan van Os

In response to

Responses

pgsql-hackers by date

Next:From: orgDate: 2007-01-22 09:32:25
Subject: STOP all user access except for admin for a few minutes?
Previous:From: Csaba NagyDate: 2007-01-22 09:15:45
Subject: Re: savepoint improvements

pgsql-bugs by date

Next:From: Tom LaneDate: 2007-01-23 05:54:01
Subject: Re: BUG #2914: SELECT query has no destination for result data
Previous:From: Vlad Dan DascalescuDate: 2007-01-22 07:28:19
Subject: BUG #2917: spi_prepare doesn't accept typename aliases such as 'integer'

pgsql-patches by date

Next:From: Simon KinsellaDate: 2007-01-22 10:50:15
Subject: FW: Possible to emulate pre-8.2 behaviour of SET CONSTRAINTS?
Previous:From: Tom LaneDate: 2007-01-22 07:07:00
Subject: Re: DROP FUNCTION failure: cache lookup failed for relation X

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group