Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Patch to log usage of temporary files

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bill Moran <wmoran(at)collaborativefusion(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Patch to log usage of temporary files
Date: 2007-01-04 14:34:42
Message-ID: 459D1082.4080305@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bill Moran wrote:
> In response to "Andrew Dunstan" <andrew(at)dunslane(dot)net>:
>
>   
>> Bill Moran wrote:
>>     
>>> Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>>       
>>>> Bill Moran wrote:
>>>>         
>>>>> + 		if (trace_temp_files != -1)
>>>>>
>>>>>           
>>>> Might be more robust to say
>>>>
>>>>     if (trace_temp_files >= 0)
>>>>         
>>> Because it would allow for the easy addition of more negative numbers
>>> with magic value?
>>>       
>> because ISTM any negative number here should mean no action is to be
>> taken. Otherwise how else is it different from 0?
>>     
>
> ??
>
> I specified in the GUC config that minimum allowable value is -1.
>
>   


OK, missed that, sorry. Please return to normal viewing ...

cheers

andrew

In response to

pgsql-hackers by date

Next:From: Simon RiggsDate: 2007-01-04 14:43:18
Subject: Re: 8.3 pending patch queue
Previous:From: Simon RiggsDate: 2007-01-04 14:27:56
Subject: wal_checksum = on (default) | off

pgsql-patches by date

Next:From: Tom LaneDate: 2007-01-04 14:56:18
Subject: Re: [HACKERS] Patch to log usage of temporary files
Previous:From: Simon RiggsDate: 2007-01-04 14:27:56
Subject: wal_checksum = on (default) | off

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group