Skip site navigation (1) Skip section navigation (2)

Re: pgstattuple TODO item

From: Dave Page <dpage(at)postgresql(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: pgstattuple TODO item
Date: 2007-01-04 08:51:10
Message-ID: 459CBFFE.4060708@postgresql.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
Guillaume Lelarge wrote:
> Hi all,

Hi,

> I worked on my TODO item tonight. You'll find a first patch attached
> (but not to be commited on SVN).

Cool :-)

> It works like the rows' count on a table. Select a table, right-click on
> the property grid, select "Execute pgstattuple". If the pgstattuple
> function doesn't exist, you'll get an error. If it is available, pgAdmin
> will refresh the property grid with the new informations.
> 
> I don't know how to handle two issues.
> 
> I didn't add some code to automatically detect if pgstattuple is
> installed. I don't know if I should add a new public method in pgCon
> class or use the HasFeature method. If the database doesn't have
> pgstattuple, should I disable the menu item or should I hide it ?

You should use HasFeature.

> I don't like the way I display all these rows. Can I put them in a new
> tab ? like the Statistics one ?

I think they should be added to the existing statistics, rather than
being on a new tab. Just extend pgTable::ShowStatistics as has already
been done for FEATURE_SIZE, and get rid of the menu item altogether.

BTW; *if* it were to be done from the menu (which I don't think it
should), you would use executePgstattupleFactory::CheckEnable to hide
the option if HasFeature fails, as well as to show of hide it depending
on the selected object type.

Regards, Dave

Responses

pgadmin-hackers by date

Next:From: Guillaume LelargeDate: 2007-01-04 09:17:03
Subject: Re: pgstattuple TODO item
Previous:From: Dave PageDate: 2007-01-04 08:23:35
Subject: Re: Patch - Solving compilation problem for Sun studio compiler

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group