Skip site navigation (1) Skip section navigation (2)

Re: pgadmin3-1.6.1 - core dumped - Fixed

From: Dave Page <dpage(at)postgresql(dot)org>
To: Dhanaraj M <Dhanaraj(dot)M(at)sun(dot)com>
Cc: Zdenek(dot)Kotala(at)sun(dot)com, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: pgadmin3-1.6.1 - core dumped - Fixed
Date: 2006-12-14 13:33:19
Message-ID: 4581529F.5030203@postgresql.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
Dhanaraj M wrote:
> Hi Dave
> 
> I dont know whether the problem is with pgAdmin or not.
> But I have a fix for this.
> 
> File name:-  src/frm/frmQuery.cpp
> 
> void frmQuery::OnChangeConnection(wxCommandEvent &ev)
> {
>     unsigned int sel=cbConnection->GetCurrentSelection();
> 
> +  if(!IsVisible())
> +       return;
> 
>     if (sel == cbConnection->GetCount()-1)
>     {
>         // new Connection
>         dlgSelectConnection dlg(this, mainForm);
>         int rc=dlg.Go(conn, cbConnection);
> ---------------------------------------------------------------------------- 
> 
> After closing the query tool, this event is called.
> So I am checking whether the window is destroyed already or not.
> Is it the right fix?
> I am testing in different machines(sparc/x-86) and report you soon.
> Please comment on this?

Dhanaraj (and Zdenek). Apologies for not being too responsive over the 
last few days - as you may have heard, I'm changing job soon so not only 
do I have the fun of handing all my work over to colleagues here, but 
I've also been spending time moving some of the PostgreSQL and pgAdmin 
project infrastructure to a new datacenter before I lose access to this one.

Anyhoo, I agree that this seems a safe fix for the problem your are 
seeing Dhanaraj and have committed it to the 1.6 branch and trunk - thanks.

What still doesn't make sense is why that function is getting called at 
all at that point. I can only imagine that wxWidgets is erroneously 
firing it when the wxCombo is destroyed.

Regards, Dave

In response to

pgadmin-hackers by date

Next:From: Hiroshi SaitoDate: 2006-12-14 13:46:51
Subject: pgAdmin3 snapshots(1.6.2) on OpenSUSE and SUSE Linux Enterprise
Previous:From: svnDate: 2006-12-14 13:12:47
Subject: SVN Commit by dpage: r5792 - in branches/REL-1_6_0_PATCHES/pgadmin3: . src/frm

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group