> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Sat, Dec 11, 2010 at 18:46, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I think we can just #define the other cases as zeroes. I'm not sure why
>>> you think that's an issue for open --- the privileges don't exist.
>> Hmm. I was/am worried about any case that specifies *just* one of the
>> permissions that don't exist. That'll leave it at zero, whereas the
>> correct one might be the user-only version of whatever (read/write)
>> was given.
> If we didn't specify the "user" read or write privilege, we shouldn't
> get it.
I put in #define's for these, and it seems to have fixed the MSVC
buildfarm members, but cygwin is still broken. How come ... doesn't
that port use port/win32.h?
> What are the values of _S_IREAD and _S_IWRITE, anyway? I'm still
> wondering how come the previous coding with hardwired constants
> behaved correctly.
Still curious about this.
regards, tom lane
In response to
pgsql-hackers by date
|Next:||From: Tomas Vondra||Date: 2010-12-12 16:23:20|
|Subject: Re: proposal : cross-column stats|
|Previous:||From: Tom Lane||Date: 2010-12-12 16:01:37|
|Subject: Re: Problem with pg_upgrade (8.4 -> 9.0) due to ALTER DATABASE SET ROLE |
pgsql-committers by date
|Next:||From: Andrew Dunstan||Date: 2010-12-12 17:22:09|
|Subject: Re: [COMMITTERS] pgsql: Use symbolic names not octal constants
for file permission flags|
|Previous:||From: Simon Riggs||Date: 2010-12-12 10:15:40|
|Subject: Re: [COMMITTERS] pgsql: Reduce spurious Hot Standby conflicts from