Skip site navigation (1) Skip section navigation (2)

Re: libedit broke in head

From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: libedit broke in head
Date: 2006-10-01 02:17:54
Message-ID: 451F2552.7000308@commandprompt.com (view raw or flat)
Thread:
Lists: pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> I think the switches are confusing ... when you are using libedit, you
>> certainly don't want readline as well, so it seems natural to disable
>> it.  I understand that what --without-readline really does is turn the
>> line-editing capability off in general rather than just readline, which
>> is confusing.

Just to verify. With removing the second switch, were good. It tested
and ran clean.

> 
> The documentation could be improved perhaps:
> 
> $ ./configure --help | grep -i edit    
>   --with-libedit-preferred  prefer BSD Libedit over GNU Readline
>   --without-readline      do not use GNU Readline / BSD Libedit line editing
> $
> 
> ISTM the second line would be clearer if it read
> 
>   --without-readline      do not use GNU Readline nor BSD Libedit for editing
> 
> Also, we probably ought to see if we can make the libedit-preferred line
> come out second.

I really don't get the libedit-preferred syntax? Why not just:

--with-libedit 	use BSD Libedit not GNU Readline
--with-readline use GNU Readline not BSD Libedit
--without-readline do not use GNU Readline nor BSD Libedit

Of course --without-readline is really a misnomer too. But
--without-edit doesn't sound right.

Sincerely,

Joshua D. Drake



> 
> 			regards, tom lane
> 


-- 

   === The PostgreSQL Company: Command Prompt, Inc. ===
Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240
   Providing the most comprehensive  PostgreSQL solutions since 1997
             http://www.commandprompt.com/



In response to

Responses

pgsql-hackers by date

Next:From: tomasDate: 2006-10-01 04:41:39
Subject: Re: New version of money type
Previous:From: Joshua D. DrakeDate: 2006-10-01 02:03:00
Subject: Re: libedit broke in head

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group