Re: [HACKERS] Incrementally Updated Backup

From: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Incrementally Updated Backup
Date: 2006-09-19 15:05:02
Message-ID: 4510071E.9080707@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Simon Riggs wrote:
> +
> + if (startupAfterRecovery)
> + ereport(ERROR,
> + (errmsg("recovery ends normally with startup_after_recovery=false")));
> +

I find this part of the patch a bit ugly. Isn't there a better way to
exit than throwing an error that's not really an error?

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Merlin Moncure 2006-09-19 15:06:36 Re: advisory locks (was: 8.2 beta blockers)
Previous Message Heikki Linnakangas 2006-09-19 14:59:07 Re: Getting rid of cmin and cmax

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2006-09-19 15:19:50 Re: Small additions and typos on backup
Previous Message Albe Laurenz 2006-09-19 14:33:57 Re: Dynamic linking on AIX