Re: pgsql: Add psql option: -1 or --single-transaction Simon Riggs

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: pgsql: Add psql option: -1 or --single-transaction Simon Riggs
Date: 2006-02-13 21:02:25
Message-ID: 4502.1139864545@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Isn't this patch emitting the BEGIN at the wrong place?

--
-- PostgreSQL database dump
--

SET client_encoding = 'SQL_ASCII';
SET check_function_bodies = false;
SET client_min_messages = warning;

BEGIN;

--
-- Name: SCHEMA public; Type: COMMENT; Schema: -; Owner: postgres
--

COMMENT ON SCHEMA public IS 'Standard public schema';

That's not what I would call guaranteeing that all the commands execute
successfully. What if the client encoding is unrecognized, for
instance?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2006-02-13 21:29:08 pgsql: Improve documentation of --single-transaction option: fix markup,
Previous Message James William Pye 2006-02-13 18:27:35 python - be: Link against LIBS var to make Python happy.