Re: [HACKERS] extension for sql update

From: Susanne Ebrecht <miracee(at)miracee(dot)de>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>, pgsql-patches(at)postgresql(dot)org, David Fetter <david(at)fetter(dot)org>, "Jim C(dot) Nasby" <jnasby(at)pervasive(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: [HACKERS] extension for sql update
Date: 2006-09-05 10:56:24
Message-ID: 44FD57D8.10001@miracee.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Bruce Momjian wrote:
> Susanne Ebrecht wrote:
>
>>>>>>>> Is it too hard to rip it back out once the full row support
>>>>>>>> arrives? That seems speculation at best anyway.
>>>>>>>>
>>>>>>>>
>>>>>>> That's what I was thinking. Glad someone else replied. ;-)
>>>>>>>
>>>>>>>
>>>>>> If you're looking for votes, +1. I'll gladly take a subset of the
>>>>>> SQL standard UPDATE table SET (...) = (...) over having nothing.
>>>>>>
>>>>>>
>>>>> +1 here, too. :)
>>>>>
>>>>>
>>>>>
>>>> +1
>>>>
>>>>
>>> I am working now to get this into 8.2.
>>>
>>>
>>>
>> I am glad to read this. But what does it mean to me? Shall I change the
>> patch someway?
>>
>
> I have merged your patch into current CVS and applied it; attached.
> There was quite a bit of code drift. One drift area was the new
> RETURNING clause; that was easy to fix. A more complex case is the
> code no longer has values as ResTargets --- it is a simple a_expr list,
> so I changed the critical assignment in gram.y from:
>
> res_col->val = (Node *)copyObject(res_val->val);
>
> to:
>
> res_col->val = (Node *)copyObject(res_val);
>
> Hope that is OK. Without that fix, it crashed. I also merged your SGML
> syntax and grammer addition into the exiting UPDATE main entry.
>
Of course it is ok. Many thanks.

Susanne

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chris Mair 2006-09-05 11:44:17 Re: ECPG regression failures on OpenBSD
Previous Message Martijn van Oosterhout 2006-09-05 10:37:10 Re: Question about 8-byte datatypes

Browse pgsql-patches by date

  From Date Subject
Next Message Michael Glaesemann 2006-09-05 11:22:04 Re: Fix PGPORT reassignment in ecpg regression tests
Previous Message Michael Meskes 2006-09-05 10:16:41 Re: Fix PGPORT reassignment in ecpg regression tests