Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] COPY view

From: Zoltan Boszormenyi <zboszor(at)dunaweb(dot)hu>
To: Zoltan Boszormenyi <zboszor(at)dunaweb(dot)hu>,Bruce Momjian <bruce(at)momjian(dot)us>,Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>,pgsql-hackers(at)postgresql(dot)org, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>,Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>,"Jim C(dot) Nasby" <jnasby(at)pervasive(dot)com>,Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>,List pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] COPY view
Date: 2006-08-23 16:15:04
Message-ID: 44EC7F08.8060804@dunaweb.hu (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Alvaro Herrera írta:
> Zoltan Boszormenyi wrote:
>
>   
>> OK, here's my current version. The reference leak is fixed.
>> But as my testcase shows, it only works for single selects
>> currently. The parser accepts it but COPY doesn't produce
>> the expected output. Please, suggest a solution.
>>     
>
> I'm not sure I agree with the approach of creating a fake "SELECT * FROM
> foo" in analyze.c in the relation case and passing it back to the parser
> to create a Query node.  That's not there in the original code and you
> shouldn't need it.  Just let the case where COPY gets a relation
> continue to handle it as it does today, and add a separate case for the
> SELECT.
>   

The exact same code was there,
e.g. parse and rewrite "SELECT * FROM view"
just not in analyze.c. I will try without it, though.


> That doesn't help you with the UNION stuff though.
>   

:-(


In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2006-08-23 16:16:02
Subject: Re: Tricky bugs in concurrent index build
Previous:From: Alvaro HerreraDate: 2006-08-23 16:10:42
Subject: Re: [HACKERS] COPY view

pgsql-patches by date

Next:From: chrisnospamDate: 2006-08-23 16:38:50
Subject: Re: [PATCHES] selecting large result sets in psql using
Previous:From: Alvaro HerreraDate: 2006-08-23 16:10:42
Subject: Re: [HACKERS] COPY view

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group