Re: GUC with units, details

From: "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Michael Glaesemann <grzm(at)seespotcode(dot)net>, Martijn van Oosterhout <kleptog(at)svana(dot)org>, "Bort, Paul" <pbort(at)tmwsystems(dot)com>, Neil Conway <neilc(at)samurai(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: GUC with units, details
Date: 2006-07-27 15:39:21
Message-ID: 44C8DE29.40405@phlo.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> Tom Lane wrote:
>>> Peter's not said exactly how he plans to deal with
>>> this, but I suppose it'll round off one way or the other ...
>
>> It'll get truncated by integer division. I wouldn't mind if someone
>> proposed a patch to create a warning or error in this case, but I
>> wanted to keep the initial version simple.
>
> I'd recommend against that. Apple recently changed OS X so that
> it rejects SHMMAX settings that aren't an exact multiple of
> something-or-other, and I've found that to be a *serious* PITA.
> Of course part of the problem is that there's no helpful message,
> but it's still a big loss from a usability standpoint, and quite
> unnecessary (every other Unix seems willing to round off...)
>
> One thought is that maybe we should round up not down? I'm having
> a hard time making a specific case either way, though.

Rounding up would have the advantage that you could just specify "0"
in the config file, and have postgres use the smallest value possible.

greetings, Florian Pflug

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Florian G. Pflug 2006-07-27 15:42:19 Re: [HACKERS] extension for sql update
Previous Message Jim Nasby 2006-07-27 15:34:59 Re: [HACKERS] Resurrecting per-page cleaner for btree