| From: | "Florian G(dot) Pflug" <fgp(at)phlo(dot)org> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org, William ZHANG <uniware(at)zedware(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Patch for VS.Net 2005's strxfrm() bug |
| Date: | 2006-07-27 00:41:55 |
| Message-ID: | 44C80BD3.5060306@phlo.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian wrote:
>>> Why is this better than:
>>>
>>> #if _MSC_VER == 1400
>>>
>>>
>>> Surely this will not be true if _MSC_VER is undefined?
>> I experienced injustice and the reason of in OSX for it.
>
> What was the problem with OSX? Did it throw a warning of you did an
> equality test on an undefined symbol?
The following if evaluated to true on osx, although I'm pretty sure that
_MSC_VER isn't defined on osx ;-)
#if (_MSC_VER < 1300)
...
#endif
replacing it with
#ifdef WIN32
#if (_MSC_VER < 1300)
...
#endif
#endif
fixed the problem.
greetings, Florian Pflug
| From | Date | Subject | |
|---|---|---|---|
| Next Message | andrew | 2006-07-27 00:48:11 | Re: [HACKERS] Patch for VS.Net 2005's strxfrm() bug |
| Previous Message | Michael Glaesemann | 2006-07-26 23:16:25 | Re: GUC with units, details |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | andrew | 2006-07-27 00:48:11 | Re: [HACKERS] Patch for VS.Net 2005's strxfrm() bug |
| Previous Message | Andrew Dunstan | 2006-07-26 22:26:11 | Re: [PATCHES] [PATCH] Provide 8-byte transaction IDs to |