Skip site navigation (1) Skip section navigation (2)

Re: Values list-of-targetlists patch for comments (was Re:

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Christopher Kings-Lynne <chris(dot)kings-lynne(at)calorieking(dot)com>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Bernd Helmle <mailings(at)oopsware(dot)de>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Susanne Ebrecht <susanne(dot)ebrecht(at)credativ(dot)de>
Subject: Re: Values list-of-targetlists patch for comments (was Re:
Date: 2006-07-24 16:32:37
Message-ID: 44C4F625.2050304@joeconway.com (view raw or flat)
Thread:
Lists: pgsql-docspgsql-hackerspgsql-patches
Tom Lane wrote:
>>
>>>There are basically two ways you could go about this:
>>>1. Make a new jointree leaf node type to represent a VALUES construct,
>>>and dangle the list of lists of expressions off that.
>>>2. Make a new RangeTblEntry type to represent a VALUES construct, and
>>>just put a RangeTblRef to it into the jointree.  The expressions
>>>dangle off the RangeTblEntry.
> 
> You seem to have done *both*, which is certainly not what I had in mind.
> I'd drop the RangeTblEntry changes, I think.

Good feedback -- thanks! But without the RTE, how would VALUES in the 
FROM clause work? Or should I just drop that part and focus on just the 
InsertStmt case?

Joe

In response to

Responses

pgsql-docs by date

Next:From: Tom LaneDate: 2006-07-24 17:09:29
Subject: Re: Values list-of-targetlists patch for comments (was Re: [HACKERS] 8.2 features?)
Previous:From: Tom LaneDate: 2006-07-24 16:12:11
Subject: Re: Values list-of-targetlists patch for comments (was Re: [HACKERS] 8.2 features?)

pgsql-hackers by date

Next:From: Peter EisentrautDate: 2006-07-24 16:33:36
Subject: Re: [PATCHES] Generic Monitoring Framework with DTrace patch
Previous:From: Joshua D. DrakeDate: 2006-07-24 16:23:08
Subject: Re: plPHP and plRuby

pgsql-patches by date

Next:From: Peter EisentrautDate: 2006-07-24 16:33:36
Subject: Re: [PATCHES] Generic Monitoring Framework with DTrace patch
Previous:From: Tom LaneDate: 2006-07-24 16:12:11
Subject: Re: Values list-of-targetlists patch for comments (was Re: [HACKERS] 8.2 features?)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group