Skip site navigation (1) Skip section navigation (2)

Re: Proposed patch for contrib/cube

From: Joshua Reich <josh(at)root(dot)net>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Proposed patch for contrib/cube
Date: 2006-07-18 15:33:32
Message-ID: 44BCFF4C.9040405@root.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Please find my cleanup of cube attached.

I have also included the cube_a_f8_f8() function to allow construction 
of a cube from 2 float8[]'s.

Thanks,

Josh Reich

Neil Conway wrote:
> On Mon, 2006-07-17 at 17:55 -0400, Joshua Reich wrote:
>> Ok. So, the cube code looks very unmaintained (not to offend anyone), 
>> but it is all in V0 and I believe make installcheck fails out of the box 
>> due to new error message formats.
> 
> It passes for me with CVS HEAD. The cube regression test is also run as
> part of the buildfarm process, so it sounds like an error on your end.
> 
>> I'm in the process of twisting the arm of another guy here to help me
>> clean up the code - if that is ok with the powers that be?
> 
> Cleanup would certainly be welcome.
> 
>> This is my first patch submission, so please let me know what heinous 
>> errors I have made
> 
> You should submit patches in context diff format (diff -c). You should
> also send a single patch for all the (related) changes you want to make,
> and you seem to have omitted the diff headers. You should generate
> patches like:
> 
> $ cvs diff                    # from the root of the source tree
> 
> or
> 
> $ diff -rc ../orig_tree .     # from the root of the modified tree
> 
> Depending on whether you're working against CVS or if you've made a copy
> of the source tree to make your changes in.
> 
>>       if (ARRNELEMS(ll) != dim)
>>       {
>>               ereport(ERROR,
>>                       (errcode(ERRCODE_ARRAY_ELEMENT_ERROR),
>>                       errmsg("UR and LL arrays must be of same
> length")));
>>               PG_RETURN_NULL();
>>       }
> 
> You don't need to return anything after ereport(ERROR) -- it won't
> return control to the caller.
> 
> -Neil
> 
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
>        subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
>        message can get through to the mailing list cleanly

Attachment: cube_v0_to_v1.diff
Description: text/plain (33.7 KB)

In response to

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2006-07-18 16:04:49
Subject: Re: [PATCHES] Proposed patch for contrib/cube
Previous:From: Joe ConwayDate: 2006-07-18 15:05:57
Subject: Re: [HACKERS] 8.2 features?

pgsql-patches by date

Next:From: Andrew DunstanDate: 2006-07-18 16:04:49
Subject: Re: [PATCHES] Proposed patch for contrib/cube
Previous:From: Joe ConwayDate: 2006-07-18 15:05:57
Subject: Re: [HACKERS] 8.2 features?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group