Skip site navigation (1) Skip section navigation (2)

Re: Backend misfeasance for DEFAULT NULL

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Backend misfeasance for DEFAULT NULL
Date: 2007-10-28 19:43:21
Message-ID: 4488.1193600601@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> Well if there's a convenient later place to add the check then sure. Will it
> mean pg_dump will have to put DEFAULT NULL everywhere though? Or can it detect
> that it's an inherited table where the default doesn't match?

The latter --- I already committed that fix.

> Perhaps it should be even later and we should store the NULL default in the
> catalog but filter it out when we build the relcache?

No, I don't think we want to be making useless pg_attrdef entries.
I do want to put the test as late as possible though, maybe even
StoreAttrDefault?

			regards, tom lane

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2007-10-28 21:12:45
Subject: Re: Backend misfeasance for DEFAULT NULL
Previous:From: Gregory StarkDate: 2007-10-28 18:14:44
Subject: Re: Backend misfeasance for DEFAULT NULL

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group