Skip site navigation (1) Skip section navigation (2)

Re: Allow commenting of variables in postgresql.conf to -

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: pgsql-patches(at)postgresql(dot)org
Cc: Joachim Wieland <joe(at)mcknight(dot)de>
Subject: Re: Allow commenting of variables in postgresql.conf to -
Date: 2006-05-31 16:13:04
Message-ID: 447DC090.7050000@sun.com (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
There is second version of patch. I made following changes:

- fix problem with assertion
- use boot_val instead default_val for all configuration data types
- add GUC_JUST_RELOAD status to track what is in configuration file or not
- revert only commented out variables
- add message what is revert to boot value

Joachim, could you explain me second point? I  cannot determine 
described problem. By my opinion my patch does not change this behavior.

Zdenek

Joachim Wieland wrote:
> Zdenek,
>   
> Three points after a quick test:
>
>  - please compile with --enable-cassert, there are wrong assertions in your
>    code (you might just have to move some lines, there is an Assert() and an
>    assignment thereafter)
>
>  - changing a PGC_POSTMASTER should show a message:
>        => parameter \"%s\" cannot be changed after server start;
>           configuration file change ignored
>    This seems to not show up anymore with your patch.
>
>  - with the same reasoning, I think it's a good idea to display a message
>    about which option falls back to its default value.
>
>
> Joachim
>
>   


Attachment: pg_conf.patch
Description: text/x-patch (13.8 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2006-05-31 16:26:21
Subject: Re: copy with compression progress n
Previous:From: Dave PageDate: 2006-05-31 15:48:12
Subject: Re: Possible TODO item: copy to/from pipe

pgsql-patches by date

Next:From: Martijn van OosterhoutDate: 2006-05-31 17:24:59
Subject: Re: [PATCH] Magic block for modules
Previous:From: Robert TreatDate: 2006-05-31 15:14:54
Subject: Update link for GUI Tools in FAQ

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group