Joe Conway <mail(at)joeconway(dot)com> writes:
> The problem exists with all three dblink_build_sql_* functions. Here is
> a more complete patch. If there are no objections I'll apply this to
> HEAD and look at back-patching -- these functions have hardly been
> touched since inception.

Do you really need to copy the relation tupdesc when you only are going
to make a one-time check of the number of attributes?  This coding would
make some sense if you intended to use the tupdesc again later in the
functions, but it appears you don't.

Also, what about cases where the relation contains dropped columns ---
it's not obvious whether this test is correct in that case.

			regards, tom lane

In response to

• Re: use of dblink_build_sql_insert() induces a server crash at 2010-02-03 18:08:16 from Joe Conway

Responses

• Re: use of dblink_build_sql_insert() induces a server crash at 2010-02-03 19:39:14 from Joe Conway

pgsql-hackers by date

Next:	From: Robert Haas	Date: 2010-02-03 18:20:57
	Subject: Re: PG 9.0 and standard_conforming_strings
Previous:	From: Joe Conway	Date: 2010-02-03 18:08:16
	Subject: Re: use of dblink_build_sql_insert() induces a server crash