Skip site navigation (1) Skip section navigation (2)

Re: [BUGS] BUG #2401: spinlocks not available on amd64

From: Robert Lor <Robert(dot)Lor(at)Sun(dot)COM>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Theo Schlossnagle <jesus(at)omniti(dot)com>, Josh(dot)Berkus(at)Sun(dot)COM,PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #2401: spinlocks not available on amd64
Date: 2006-05-04 19:17:56
Message-ID: 445A5364.4090307@Sun.COM (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-patches
Hi Bruce,

The new SPARC assembly file src/backend/port/tas/solaris_sparc.s uses / 
instead of ! for comments, and as a result the compile fails with Sun 
Studio 11.  Please modify the first 3 lines to look like the following.

> !=======================================================================
> ! solaris_sparc.s -- compare and swap for solaris_sparc
> !=======================================================================



Thanks!

-Robert


Bruce Momjian wrote On 04/29/06 17:16,:

>Tom Lane wrote:
>  
>
>>Theo Schlossnagle <jesus(at)omniti(dot)com> writes:
>>    
>>
>>>I'd remind everyone that the spinlock stuff is entirely optional at 
>>>build time.
>>>      
>>>
>>Not really.  The performance hit for not having hardware spinlocks is
>>so severe that it's not considered a reasonable fallback.
>>
>>    
>>
>>>I also think it immensely useful to replace all of the tas subsystem 
>>>with cas so that one could reliabily lock these atomics with the process 
>>>id of the locker.
>>>      
>>>
>>I cannot, ever once in my years working on Postgres, remember having
>>wanted such a thing.  I am strongly against mucking with the spinlock
>>code for mere aesthetics --- it's too fragile and hard to test,
>>especially on platforms you don't have ready access to.
>>
>>In short, it ain't broken and we don't need to fix it.
>>    
>>
>
>Agreed.  Should the new Solaris ASM code be modified?
>
>  
>

In response to

Responses

pgsql-bugs by date

Next:From: Tang, GuoDate: 2006-05-04 21:10:46
Subject: question on PostgreSQL\8.0\pgAdmin III
Previous:From: Casey DuncanDate: 2006-05-04 17:23:12
Subject: ERROR: out of memory, running aggregate query

pgsql-patches by date

Next:From: Tom LaneDate: 2006-05-04 19:36:53
Subject: Re: patch review, please: Autovacuum/Vacuum times via stats.
Previous:From: Martijn van OosterhoutDate: 2006-05-04 18:46:24
Subject: Re: [PATCH] Have configure complain about unknown options

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group