Re: -HEAD pg_dumpall broken against older backends

From: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: -HEAD pg_dumpall broken against older backends
Date: 2006-03-29 17:58:37
Message-ID: 442ACACD.9050103@kaltenbrunner.cc
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Peter Eisentraut wrote:
> Stefan Kaltenbrunner wrote:
>
>>looks like somebody forgot to test some changes to the pg_dumpall
>>code in Revision 1.70 against <8.1 installations - resulting in the
>>following syntax error:
>
>
> Dump output is never expected to be backward compatible.

yeah - but if you take a look at the code/patch you will see that the
problem in this case is that pg_dumpall generates invalid SQL if it is
operating against an older backend which is an obvious typo/thinko in
this case.
It has nothing to do with generating backwards compatible dumps - and
using the pg_dumpall from the (newer) target version for upgrades has
been recommended for a while (or rather is documented to work in the
manual) I think.

Stefan

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message David Fetter 2006-03-29 20:24:51 Win32 sysconfig -> pg_service.conf
Previous Message Andrew Dunstan 2006-03-29 17:48:13 Re: -HEAD pg_dumpall broken against older backends