Re: [PATCHES] pg_freespacemap question

From: Mark Kirkwood <markir(at)paradise(dot)net(dot)nz>
To: Mark Kirkwood <markir(at)paradise(dot)net(dot)nz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>, alvherre(at)commandprompt(dot)com, peter_e(at)gmx(dot)net, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] pg_freespacemap question
Date: 2006-03-19 23:33:33
Message-ID: 441DEA4D.9000804@paradise.net.nz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Mark Kirkwood wrote:
> Tom Lane wrote:
>
>>
>> I do notice a rather serious shortcoming of pg_freespacemap in its
>> current incarnation, which is that it *only* shows you the per-page free
>> space data, and not any of the information that would let you determine
>> what the FSM is doing to filter the raw data. The per-relation
>> avgRequest and lastPageCount fields would be interesting for instance.
>> Perhaps there should be a second view with one row per relation to
>> carry the appropriate data.
>>
>
> Ok - I did wonder about 2 views, but was unsure if the per-relation
> stuff was interesting. Given that it looks like it is interesting, I'll
> see about getting a second view going.
>

This patch implements the second view for FSM relations. I have renamed
the functions and views to be:

pg_freespacemap_relations
pg_freespacemap_pages

This patch depends on the previous one (which was called simply
'pg_freespacemap.patch').

Cheers

Mark

Attachment Content-Type Size
pg_freespacemap-1.patch.gz application/gzip 4.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jan Cruz 2006-03-20 02:35:24 Re: suggestion
Previous Message Devrim GUNDUZ 2006-03-19 23:08:26 Re: [HACKERS] PostgreSQL Anniversary Proposals --

Browse pgsql-patches by date

  From Date Subject
Next Message Mark Kirkwood 2006-03-19 23:39:18 Pg_buffercache tidy
Previous Message Andreas Pflug 2006-03-19 11:22:45 Re: Automatically setting work_mem