Skip site navigation (1) Skip section navigation (2)

Re: plpython tracebacks

From: Neil Conway <neilc(at)samurai(dot)com>
To: "P(dot) Scott DeVos" <scott(at)countrysidetechnology(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: plpython tracebacks
Date: 2006-02-22 22:47:26
Message-ID: 43FCE9FE.9010106@samurai.com (view raw or flat)
Thread:
Lists: pgsql-patches
P. Scott DeVos wrote:
> I'm on it.

Actually, don't worry about it -- I've made the corrections I had in 
mind myself. Attached is a revised patch. On looking closer, I didn't 
really like the way the patch accumulated the lines of the traceback: 
AFAICS _PyString_Join() is not an "official" Python C API function (it's 
not documented, at any rate), and besides it is cleaner and more 
efficient to build up the traceback string in a StringInfo rather than 
using Python lists and strings.

The attached patch isn't quite finished: "No Traceback" when there is no 
traceback information doesn't seem like the best message, I need to 
update the regression tests and some comments, etc. But I plan to apply 
something similar in substance to the attached patch to HEAD in the next 
day or two, barring objections.

-Neil

Attachment: plpython_trace-1.patch
Description: text/x-patch (3.6 KB)

In response to

Responses

pgsql-patches by date

Next:From: P. Scott DeVosDate: 2006-02-22 23:30:39
Subject: Re: plpython tracebacks
Previous:From: Magnus HaganderDate: 2006-02-22 21:38:15
Subject: Re: [PATCH] Prompt for password on Windows platforms

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group