P. Scott DeVos wrote:
> I'm on it.
Actually, don't worry about it -- I've made the corrections I had in
mind myself. Attached is a revised patch. On looking closer, I didn't
really like the way the patch accumulated the lines of the traceback:
AFAICS _PyString_Join() is not an "official" Python C API function (it's
not documented, at any rate), and besides it is cleaner and more
efficient to build up the traceback string in a StringInfo rather than
using Python lists and strings.
The attached patch isn't quite finished: "No Traceback" when there is no
traceback information doesn't seem like the best message, I need to
update the regression tests and some comments, etc. But I plan to apply
something similar in substance to the attached patch to HEAD in the next
day or two, barring objections.
In response to
pgsql-patches by date
|Next:||From: P. Scott DeVos||Date: 2006-02-22 23:30:39|
|Subject: Re: plpython tracebacks|
|Previous:||From: Magnus Hagander||Date: 2006-02-22 21:38:15|
|Subject: Re: [PATCH] Prompt for password on Windows platforms |