From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Magnus Hagander <mha(at)sollentuna(dot)net>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: pgxs/windows |
Date: | 2006-01-15 23:02:30 |
Message-ID: | 43CAD486.5080607@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
>Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>
>>I doubt DESTDIR is having an effect. From what I can see we hardly use
>>it so it will mostly be blank:
>>
>>
>
>Yes, it is often an empty string, which doubtless explains how an error
>of this sort could sneak in. But I think there's no doubt that one or
>the other of those definitions is wrong. I'm not completely sure which
>though. DESTDIR should be included if we are referencing the
>installation tree at build time, but perhaps not for post-install
>purposes, which is the environment that PGXS should deal with.
>
>
Right.
So we should probably change $(DESTDIR)$(bindir) to $(libdir) in the
following places:
Makefile.aix:BE_DLLLIBS=
-Wl,-bI:$(DESTDIR)$(bindir)/postgres/$(POSTGRES_IMP)
Makefile.cygwin:BE_DLLLIBS= -L$(DESTDIR)$(bindir) -lpostgres
Makefile.darwin:BE_DLLLIBS= -bundle_loader $(DESTDIR)$(bindir)/postgres
Makefile.win32:BE_DLLLIBS= -L$(DESTDIR)$(bindir) -lpostgres
But I'm punting slightly on AIX and Darwin, as I know nothing of
building there.
cheers
andrew
> regards, tom lane
>
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-01-15 23:03:12 | ScanKey representation for RowCompare index conditions |
Previous Message | Tom Lane | 2006-01-15 22:02:54 | Re: pgxs/windows |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2006-01-15 23:08:31 | Re: pgxs/windows |
Previous Message | Neil Conway | 2006-01-15 22:57:50 | Re: patch to create system view that lists cursors |