Re: [PATCHES] snprintf() argument reordering not working

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Nicolai Tufar <ntufar(at)gmail(dot)com>, devrim(at)kivi(dot)com(dot)tr, Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] snprintf() argument reordering not working
Date: 2005-12-04 18:53:06
Message-ID: 43933B12.7090600@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan wrote:

>
> Tom said:
>
>> Would it work to modify c.h so that it #include's libintl.h, then
>> #undefs
>> these macros, then #includes port.h to define 'em the way we want?
>> Some or all of this might need to be #ifdef WIN32, but that seems like
>> a reasonably noninvasive solution if it can work.
>>
>
> IIRC last time I tried this it didn't work too well ;-( I will have
> another go. I think it's the best way to go.
>
>

progress so far: I undid the config changes Bruce had made and undefined
printf, fprintf, sprintf, snprintf and vsnprintf after the include of
libintl.h in include/c.h. Then to clean up some warnings I undefined
vsnprintf and snprintf in interfaces/libpq/win32.h before their
redefinition.

That got me through the backend compile and through libpq to ecpg, which
fell over at the link stage complaining about missing references to
pg_sprintf and pg_snprintf ... not sure how to fix that - windows
experts, please advise.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Martijn van Oosterhout 2005-12-04 18:55:05 Re: Upcoming PG re-releases
Previous Message Pollard, Mike 2005-12-04 18:47:33 Re: generalizing the planner knobs

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-12-04 18:57:44 Re: [PATCHES] snprintf() argument reordering not working
Previous Message Andrew Dunstan 2005-12-04 16:09:48 Re: [PATCHES] snprintf() argument reordering not working