Skip site navigation (1) Skip section navigation (2)

Re: Default extension for sql scripts

From: "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>
To: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Default extension for sql scripts
Date: 2005-10-26 15:56:10
Message-ID: 435FA71A.2030800@phlo.org (view raw or flat)
Thread:
Lists: pgadmin-hackers
Dave Page wrote:
>>>>On a related note - Does it work on windows to double-click  a saved
>>>>query,

>>>>and have pgadmin3 start _and_ open the query in a query window?
>>>No, because pgAdmin can't guess from your script which server it should
>>>connect to.

>>Well, thats fixed in 1.4 afaik - one can now switch the db-connection of a
>>query window, can't one?. The sql-file coul be opened in a query window
>>  with no
>>selected connection, and the user could chosse the connection afterwards.
>>Does this sound reasonable?
> 
> Yes.
> 
> BTW, I should really backout your earlier patch until after 1.4-STABLE is
> branched - I didn't realise you were starting on new functionality, probably
> because I didn't get your original email.

Well, sorry for that, I didn't mean to "sneak the patch in"..
But I didn't plan to submit patches for actually opening a saved query
with a double-click before 1.4 was branched. I just wanted to make 
pgAdmin3 announce the extension .sql, and provide an icon for it - 
something I more or less consider to be part of "behaving like a good
osx citizen". That pgAdmin3 now actually starts when double-clicking a
saved query (Well, at least if you named your file *.sql) is more a
byproduct of announcing the type in the Info.plist, and providing an Icon.

It's up to you, of course, to decide how to go forward with this.
My plan would be to fix the "add .sql extension to filename" bug
for 1.4, but to leave the "open query with double-click" thing
for 1.4.1 at least. I belive the Info.plist changes I sent are still
ok for 1.4 - even if it's a bit strange that pgadmin will startup on
double-clicking a file, but won't actually open the query. If you
deem that behaviour unacceptably, then I could try to figure out
how to prevent it.

greetings, Florian Pflug

In response to

Responses

pgadmin-hackers by date

Next:From: Dave PageDate: 2005-10-27 05:38:10
Subject: Re: Default extension for sql scripts
Previous:From: Alvaro HerreraDate: 2005-10-25 20:33:45
Subject: Re: Replaying archived wal files after a dump restore?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group