Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Patching dblink.c to avoid warning about

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>,PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>,David Fetter <david(at)fetter(dot)org>,Jonathan Beit-Aharon <jbeitaharon(at)intrusic(dot)com>
Subject: Re: [HACKERS] Patching dblink.c to avoid warning about
Date: 2005-10-17 02:21:12
Message-ID: 43530A98.3020507@joeconway.com (view raw or flat)
Thread:
Lists: pgsql-patches
Tom Lane wrote:
> I think it would be shorter and clearer to write
> 
> 	remoteConn  *remconn = NULL;
> 	...
> 	remconn = rconn;
> 	...
> 	remconn->newXactForCursor = TRUE;
> 
> Also, you might be able to combine this variable with the existing
> rconn local variable and thus simplify the code even more.

Thanks for the review Tom -- as usual, great suggestions. The attached 
(simpler) patch makes use of your advice. If there are no objections, 
I'll apply this tomorrow evening.

Joe

Attachment: current.dblink.2.diff
Description: text/x-patch (15.2 KB)

In response to

Responses

pgsql-patches by date

Next:From: NosyManDate: 2005-10-17 06:55:50
Subject: Can I use variable to store sql data?
Previous:From: Tom LaneDate: 2005-10-16 22:10:38
Subject: Re: Will PQregisterThreadLock() be documented?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group