Quick Links

Patching dblink.c to avoid warning about open transaction

From:	Jonathan Beit-Aharon <jbeitaharon(at)intrusic(dot)com>
To:	pgsql-hackers(at)postgresql(dot)org
Cc:	Jonathan Beit-Aharon <jbeitaharon(at)intrusic(dot)com>
Subject:	Patching dblink.c to avoid warning about open transaction
Date:	2005-09-23 20:26:56
Message-ID:	43346510.3050405@intrusic.com
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Thread:
Lists:	pgsql-hackers pgsql-patches

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#3333ff">
<meta content="text/html;charset=ISO-8859-1" http-equiv="Content-Type">
<title></title>
Hi, 
I'm not a member of this list (yet), so please
CC me on responses and
discussion. 
 
The patch below seems to be completion of work already
started, because the boolean remoteTrFlag was already defined, and all
I had to add was its setting and two references. 
 
I hope someone will find it useful, 
Jonathan 
 
 
--- dblink.c    Sat Jan  1 00:43:05 2005 
+++ /home/jbeitaharon/dev/third/postgreSQL/contrib/dblink/dblink.c     
Thu Sep 22 16:10:20 2005 
@@ -329,12 +329,16 @@ 
 
        if (!conn) 
                DBLINK_CONN_NOT_AVAIL; 
+ 
+       if (rcon) 
+               rcon->remoteTrFlag = (PQtransactionStatus(conn) !=
PQTRANS_IDLE); 
 
-       res = PQexec(conn, "BEGIN"); 
-       if (PQresultStatus(res) != PGRES_COMMAND_OK) 
-               DBLINK_RES_INTERNALERROR("begin error"); 
- 
-       PQclear(res); 
+       if ((!rcon) || (!(rcon->remoteTrFlag))) { 
+               res = PQexec(conn, "BEGIN"); 
+               if (PQresultStatus(res) != PGRES_COMMAND_OK) 
+                       DBLINK_RES_INTERNALERROR("begin error"); 
+               PQclear(res); 
+       } 
 
        appendStringInfo(str, "DECLARE %s CURSOR FOR %s", curname, sql); 
        res = PQexec(conn, str->data); 
@@ -424,12 +428,13 @@ 
 
        PQclear(res); 
 
-       /* commit the transaction */ 
-       res = PQexec(conn, "COMMIT"); 
-       if (PQresultStatus(res) != PGRES_COMMAND_OK) 
-               DBLINK_RES_INTERNALERROR("commit error"); 
- 
-       PQclear(res); 
+       if ((!rcon) || (!(rcon->remoteTrFlag))) { 
+               /* commit the transaction */ 
+               res = PQexec(conn, "COMMIT"); 
+               if (PQresultStatus(res) != PGRES_COMMAND_OK) 
+                       DBLINK_RES_INTERNALERROR("commit error"); 
+               PQclear(res); 
+       } 
 
        PG_RETURN_TEXT_P(GET_TEXT("OK")); 
 }
</body>
</html>

Attachment	Content-Type	Size
unknown_filename	text/html	3.9 KB

Responses

Re: Patching dblink.c to avoid warning about open transaction at 2005-09-23 21:31:37 from Tom Lane
Re: [HACKERS] Patching dblink.c to avoid warning about open transaction at 2005-10-07 02:38:54 from Bruce Momjian

Browse pgsql-hackers by date

	From	Date	Subject
Next Message	Bruce Momjian	2005-09-23 20:32:05	Re: Improved \df(+) in psql + backward-compatibility
Previous Message	Ron Peacetree	2005-09-23 19:44:54	Re: [PERFORM] Releasing memory during External sorting?

Browse pgsql-patches by date

	From	Date	Subject
Next Message	Bruce Momjian	2005-09-23 20:32:05	Re: Improved \df(+) in psql + backward-compatibility
Previous Message	Bruce Momjian	2005-09-23 19:59:11	Re: be-secure.c patch