Re: Appropriate wxLongLong method?

From: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
To: Hiroshi Saito <saito(at)inetrt(dot)skcapi(dot)co(dot)jp>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Appropriate wxLongLong method?
Date: 2005-09-10 17:42:27
Message-ID: 43231B03.50501@pse-consulting.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hiroshi Saito wrote:
> Hi Andreas.
>
> Now, am only I strange?

I don't know... :-)

>
> base/base.cpp: In function `wxString NumToStr(wxLongLongNative)':
> base/base.cpp:130: cannot pass objects of non-POD type `class wxLongLong'

Very weird. This has to be checked with your compiler, together with
wxLongLongFmtSpec. For my 2.6 Linux with gcc3.4, wxLongLongFmtSpec is
"ll" (ell-ell), so the resulting printf format string is %lld, requiring
a long long passed by value as argument. Apparently there's some
mismatch for your compiler.

> #else
> #ifdef __FreeBSD__
> -#define atolonglong(str) strtoll(str, (char **)NULL, 10)
> +#define atolonglong(str) strtoll(str, NULL, 10)
> #else

More weird. What's the required argument for strtoll for your platform?
I'm quite sure the (char**) cast was invented to match system header's
needs, so other FreeBSD versions might fail after your patch.

Regards,
Andreas

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message svn 2005-09-10 18:00:43 SVN Commit by andreas: r4435 - trunk/pgadmin3/src/schema
Previous Message svn 2005-09-10 17:31:12 SVN Commit by andreas: r4434 - trunk/pgadmin3/src/include/images