| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Petr Jelinek <pjmodos(at)seznam(dot)cz> |
| Cc: | pgsql-patches(at)postgresql(dot)org, dpage(at)vale-housing(dot)co(dot)uk, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Chuck McDevitt <cmcdevitt(at)greenplum(dot)com> |
| Subject: | Re: [HACKERS] Proposed patch to getaddrinfo.c to support |
| Date: | 2005-08-25 13:30:49 |
| Message-ID: | 430DC809.8040806@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Petr Jelinek wrote:
> Dave Page wrote:
>
>> It, or some related patch appears to have broken the build on
>> buildfarm member snake.
>>
>> I haven't had time to investigate.
>>
>> /D
>
>
> Atached patch fixes it and also adds proper gai_strerror for windows.
> (It's patch against CVS *after* Chucks patch was aplied)
>
I thought this had been tested. I should have tested it myself. Apologies.
Anyway, with Petr's extra patch I get a clean build, but "make check"
fails with a postmaster bind failure and a pgsql failure, both with and
without IPv6 installed, on my Xp-PRO SP1 box. When IPv6 is installed it
complains about an unknown family 23 (which is Windows-speak for AF_INET6).
So, not quite there yet.
I'm out of action for pretty much the rest of today and tomorrow, so
won't be doing more testing for a while.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Sabino Mullane | 2005-08-25 13:41:54 | Re: API like mysql_ping |
| Previous Message | Bruno Wolff III | 2005-08-25 13:00:47 | Re: TODO questions |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2005-08-25 17:52:13 | Re: [HACKERS] Proposed patch to getaddrinfo.c to support |
| Previous Message | Ilia Kantor | 2005-08-25 12:53:40 | CRC32 function |