| From: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, Dave Page <dpage(at)vale-housing(dot)co(dot)uk> |
| Subject: | Re: [HACKERS] For review: Server instrumentation patch |
| Date: | 2005-08-13 15:43:07 |
| Message-ID: | 42FE150B.3070407@pse-consulting.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Tom Lane wrote:
> Andreas Pflug <pgadmin(at)pse-consulting(dot)de> writes:
>
>>Bruce Momjian wrote:
>>
>>>Well, if they mix log files and non-log files in the same directory, we
>>>would have to filter based on the log_filename directive in the
>>>application, or use LIKE in a query.
>
>
>>.. which is what pg_logdir_ls does. And it's robust against filenames
>>that don't have valid dates too; imagine postgresql-2005-01-01_crash1.log.
>
>
> The proposed version of pg_logdir_ls could not be called "robust" in any
> way at all, considering that it fails as soon as you modify the log_filename
> pattern.
This is caused by the exposure of log_filename, I never proposed to do
that for good reasons. Any try to interpret it and read files back will
break finally when log_filename is changed at runtime, i.e. it's a
'break me' option by design.
Regards,
Andreas
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Pflug | 2005-08-13 15:50:30 | Re: [HACKERS] For review: Server instrumentation patch |
| Previous Message | Bruce Momjian | 2005-08-13 15:29:12 | Re: [patch 0/7] more patches for pgcrypto |