Skip site navigation (1) Skip section navigation (2)

Re: work in progress: timestamp patch

From: Oliver Jowett <oliver(at)opencloud(dot)com>
To: Dave Cramer <pg(at)fastcrypt(dot)com>
Cc: "pgsql-jdbc(at)postgresql(dot)org" <pgsql-jdbc(at)postgresql(dot)org>
Subject: Re: work in progress: timestamp patch
Date: 2005-07-26 05:23:28
Message-ID: 42E5C8D0.1080102@opencloud.com (view raw or flat)
Thread:
Lists: pgsql-jdbc
Dave Cramer wrote:

> I've been messing with it a bit myself, and noticed that 
> TimeStampUtils.toString used the timezone of the incoming
> timestamp, not the calendar. So the call to appendTimeZone, passes in 
> the timestamp, not the new calendar.

I looked at this and the current code is certainly wrong. The timezone
offset of a Timestamp (deprecated method!) returns the offset of the
JVM's default timezone always. We should indeed be passing the target
calendar and using that.

I've added that change to my patch. Interestingly none of the regression
tests fail with it changed; we're very short on tests that actually test
the with-Calendar code..

-O

In response to

Responses

pgsql-jdbc by date

Next:From: Gary ChenDate: 2005-07-26 05:40:39
Subject: UNSUBSCRIBE
Previous:From: Oliver JowettDate: 2005-07-26 03:31:59
Subject: Re: work in progress: timestamp patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group