| From: | Satoshi Nagayasu <nagayasus(at)nttdata(dot)co(dot)jp> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | josh(at)agliodbs(dot)com, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Open items |
| Date: | 2005-06-30 06:47:52 |
| Message-ID: | 42C39598.70301@nttdata.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
>>My patch counts inittapes(), tuplesort_begin_heap() and
>>tuplesort_begin_index(), and collect them, and sum them through the
>>stat collector.
>
>
> Hm, that doesn't seem like quite the right level to be counting at.
> Shouldn't you be hacking fd.c to count operations on FD_XACT_TEMPORARY
> files?
Why do you think so?
I don't see tuplesort.c is good or not.
But all code of sort operations are in tuplesort.c.
So I thought it is a good place to count them up.
Of course, I can move my code to fd.c if it will be reasonable.
--
NAGAYASU Satoshi <nagayasus(at)nttdata(dot)co(dot)jp>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | falcon | 2005-06-30 08:31:19 | Re: contrib/rtree_gist into core system? |
| Previous Message | Tom Lane | 2005-06-30 03:54:12 | Re: Build errors latest CVS freebsd |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adrian Maier | 2005-06-30 07:34:51 | psql patch for displaying the username when asking password |
| Previous Message | Matthew T. O'Connor | 2005-06-30 04:34:17 | Re: Autovacuum integration patch |