Re: [PATCH] Appbundle-Support for 1.2

From: Raphaël Enrici <blacknoz(at)club-internet(dot)fr>
To: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
Cc: fgp(at)phlo(dot)org, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Appbundle-Support for 1.2
Date: 2005-05-13 19:15:14
Message-ID: 4284FCC2.4050505@club-internet.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Dave Page wrote:
>
>
>
>>-----Original Message-----
>>From: blacknoz(at)club-internet(dot)fr [mailto:blacknoz(at)club-internet(dot)fr]
>>Sent: 13 May 2005 16:49
>>To: Dave Page; fgp(at)phlo(dot)org; pgadmin-hackers(at)postgresql(dot)org
>>Subject: Re: Re: [pgadmin-hackers] [PATCH] Appbundle-Support for 1.2
>>
>>Hi Dave, Florian,
>>
>>----Message d'origine----
>>
>>>Sujet: Re: [pgadmin-hackers] [PATCH] Appbundle-Support for 1.2
>>>Date: Fri, 13 May 2005 12:55:32 +0100
>>>De: "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>
>>>A: "Florian G. Pflug" <fgp(at)phlo(dot)org>,
>>>
>>>Thanks Florian - patch applied.
>>>
>>>Can you test and confirm the committed version works OK please? I'll
>>>probably need you to do so again following any changes that
>>
>>Raph submits
>>
>>>for Debian if that's OK.
>>
>>I just took a quick look to the patch provided by Florian. I
>>didn't try the build yet and I may be wrong, but to me it
>>does not handle the "DESTDIR" problem and refers to PREFIX,
>>not DESTDIR.
>>However, I'll try that tonight. Florian, can you confirm you
>>were referring to DESTDIR and not PREFIX ?
>>Is there some magic that make PREFIX take DESTDIR as a parameter ?
>>
>
>
> Gmake/automake/autoconf is all black magic for me, hence why I'd rather
> tackle one problem on on OS (that I don't have) at a time :-)

So, let's continue the twist :)

attached is the patch that works for me and keeps what was added by
Florian. As I understand it, $(PREFIX) is the equivalent to "my"
$(DESTDIR). Is it specific to Mac OS X ? If not and if it can be
replaced by DESTDIR, I'd suggest removing "$(PREFIX)" ref from Makefile.am.

Florian, what do you think about it?

Regards,
Raphaël

Attachment Content-Type Size
i18n.patch text/x-patch 930 bytes

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Raphaël Enrici 2005-05-13 19:18:16 Re: Pg 1.3 snapshot 5-12 on open error
Previous Message Patrick Hatcher 2005-05-13 18:10:28 Re: Pg 1.3 snapshot 5-12 on open error