i18n Makefile for 1.3.0 does not handle DESTDIR correctly

From: Raphaël Enrici <blacknoz(at)club-internet(dot)fr>
To: Dave Page <dpage(at)vale-housing(dot)co(dot)uk>, PgAdmin Hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: i18n Makefile for 1.3.0 does not handle DESTDIR correctly
Date: 2005-05-12 22:08:49
Message-ID: 4283D3F1.30307@club-internet.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

the Makefile in i18n pgadmin3 directory does not handle properly DESTDIR
and tries to install files directly in the prefix.

Example of failed session:
...
/usr/bin/make install DESTDIR=/home/pga3/1.3.0/pgadmin3-1.3.0/debian/tmp
make[1]: Entering directory `/home/pga3/1.3.0/pgadmin3-1.3.0'
Making install in i18n
make[2]: Entering directory `/home/pga3/1.3.0/pgadmin3-1.3.0/i18n'
make[3]: Entering directory `/home/pga3/1.3.0/pgadmin3-1.3.0/i18n'
make[3]: Nothing to be done for `install-exec-am'.
/home/pga3/1.3.0/pgadmin3-1.3.0/config/install-sh -d
/usr/share/pgadmin3/i18n
mkdir: cannot create directory `/usr/share/pgadmin3': Permission denied
make[3]: *** [install-data-local] Error 1
make[3]: Leaving directory `/home/pga3/1.3.0/pgadmin3-1.3.0/i18n'
make[2]: *** [install-am] Error 2
make[2]: Leaving directory `/home/pga3/1.3.0/pgadmin3-1.3.0/i18n'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/home/pga3/1.3.0/pgadmin3-1.3.0'
make: *** [install] Error 2

Would this be possible to correct this please ? The patch attached
should do the trick although not well tested.

Regards,
Raphaël

Attachment Content-Type Size
i18n.patch text/x-patch 933 bytes

Browse pgadmin-hackers by date

  From Date Subject
Next Message Raphaël Enrici 2005-05-12 22:18:37 Re: Pg 1.3 snapshot 5-12 on open error
Previous Message Patrick Hatcher 2005-05-12 22:00:30 Pg 1.3 snapshot 5-12 on open error