Re: Added columns to pg_stat_activity

From: Neil Conway <neilc(at)samurai(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Magnus Hagander <mha(at)sollentuna(dot)net>, Jan Wieck <JanWieck(at)Yahoo(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Added columns to pg_stat_activity
Date: 2005-05-09 02:34:07
Message-ID: 427ECC1F.20900@samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> I'd vote against that. The mechanism is lossy by design

Is it _lossy_, or merely unordered? While UDP doesn't guarantee message
delivery, I wonder what kind of extreme circumstances would need to
exist for you to lose UDP packets outright over the loopback interface.

> I don't think it's acceptable to refuse to display information
> we do have (queries, access counts) just because we don't have every
> element of a rather-arbitrarily-chosen view row.

Is there really any point in returning such incomplete statistics data?
ISTM it would mostly serve to complicate the lives of people writing
automated tools to query statistics data, for example.

> Looking at the code, backendid seems sufficient since that is the
> lookup key.

Not if you want to distinguish between dead and live backends, it's not
(see pgstat_add_backend).

-Neil

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-05-09 02:46:12 Re: Added columns to pg_stat_activity
Previous Message Tom Lane 2005-05-09 02:24:19 Re: Added columns to pg_stat_activity