Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Regression tests for security_barrier views.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Regression tests for security_barrier views.
Date: 2012-01-20 19:58:22
Message-ID: 4277.1327089502@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Robert Haas <rhaas(at)postgresql(dot)org> writes:
> Regression tests for security_barrier views.

This patch broke the regression tests for any scenario where you run the
tests multiple times without an initdb, because it creates a role and
fails to drop it.

More generally, please do not use role names as generic as "alice" in
regression tests, as that could have disastrous effects if someone
were to run the regression tests in a live installation.  We have a
convention of using "regressuser1" and so forth.

			regards, tom lane

In response to

Responses

pgsql-committers by date

Next:From: Robert HaasDate: 2012-01-21 05:14:57
Subject: Re: pgsql: Regression tests for security_barrier views.
Previous:From: Magnus HaganderDate: 2012-01-20 13:00:43
Subject: pgsql: Check number of fields in IDENTIFY_SYSTEM response

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group