Re: [HACKERS] contrib/pg_buffercache

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Mark Kirkwood <markir(at)paradise(dot)net(dot)nz>
Cc: Neil Conway <neilc(at)samurai(dot)com>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] contrib/pg_buffercache
Date: 2005-03-31 12:31:44
Message-ID: 424BEDB0.6090706@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Mark Kirkwood wrote:

> Neil Conway wrote:
>
>> Andrew Dunstan wrote:
>>
>>> I have confirmed that the attached patch works on Cygwin as well as
>>> Windows. Please apply.
>>
>>
>>
>> Applied, thanks.
>>
>
>
> Great that it fixes it... however, I had submitted a tidier patch that
> puts the macro in the header (probably after asking Andrew to test the
> first one, oops - sorry Andrew). I have tested it on win32 native.
>
> Do you want to back out the first one and use this instead?
>
>
>

I didn't see the original of the later patch, which is why I sent in
mine. I honestly don't care that much either way, although I'm inclined
to agree that the header file is just unnecessary noise.

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christopher Kings-Lynne 2005-03-31 12:53:53 Re: Bug in DROP NOT NULL
Previous Message Simon Riggs 2005-03-31 11:37:22 Re: Understanding pg_xlog

Browse pgsql-patches by date

  From Date Subject
Next Message Christopher Kings-Lynne 2005-03-31 12:53:53 Re: Bug in DROP NOT NULL
Previous Message Christopher Kings-Lynne 2005-03-31 09:06:06 Bug in DROP NOT NULL