| From: | Mark Kirkwood <markir(at)paradise(dot)net(dot)nz> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] contrib/pg_buffercache |
| Date: | 2005-03-31 08:25:32 |
| Message-ID: | 424BB3FC.30907@paradise.net.nz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Neil Conway wrote:
> Mark Kirkwood wrote:
>
>> Great that it fixes it... however, I had submitted a tidier patch that
>> puts the macro in the header
>
>
> How is this tidier?
>
err... puts the macro in the header....
> (I don't see a reason for pg_buffercache_pages.h at all, actually.)
>
(chuckles) - well, that puts a different complexion on it, best leave it
as is then! (in fact, feel free to move the declaration from
pg_buffercache_pages.h to pg_buffercache_pages.c, and eliminate the
header altogether)
cheers
Mark
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christopher Kings-Lynne | 2005-03-31 09:06:06 | Bug in DROP NOT NULL |
| Previous Message | Marian POPESCU | 2005-03-31 08:23:59 | Re: ARC patent |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christopher Kings-Lynne | 2005-03-31 09:06:06 | Bug in DROP NOT NULL |
| Previous Message | Neil Conway | 2005-03-31 06:56:52 | Re: [HACKERS] contrib/pg_buffercache |