| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Neil Conway <neilc(at)samurai(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: locks in CREATE TRIGGER, ADD FK |
| Date: | 2005-03-23 01:32:58 |
| Message-ID: | 4240C74A.1020201@samurai.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Neil Conway wrote:
> AndrewSN pointed out on IRC that ALTER TABLE ... ADD FOREIGN KEY and
> CREATE TRIGGER both acquire AccessExclusiveLocks on the table they are
> adding triggers to (the PK table, in the case of ALTER TABLE). Is this
> necessary? I don't see why we can't allow SELECT queries on the table to
> proceed while the trigger is being added.
Attached is a patch that changes both to use ShareRowExclusiveLock, and
updates the documentation accordingly. I'll apply this later today,
barring any objections.
-Neil
| Attachment | Content-Type | Size |
|---|---|---|
| create_trigger_lock-1.patch | text/x-patch | 2.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christopher Kings-Lynne | 2005-03-23 01:40:21 | Re: locks in CREATE TRIGGER, ADD FK |
| Previous Message | Christopher Kings-Lynne | 2005-03-23 01:32:47 | Re: Using new copy libpq functions on a v2 protocol backend |