Skip site navigation (1) Skip section navigation (2)

Re: Makefile breakage

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Makefile breakage
Date: 2005-03-25 03:05:57
Message-ID: 4240.1111719957@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom Lane wrote:
>> I think you should leave the $(libpq) macro alone and add a $(libpgport)
>> macro ... and yes, you will have to go around and modify the client
>> program Makefiles individually.

> How is this?  It creates a new $(libpq_only) for library usage. 
> ecpglib/Makefile is the only place I saw that can use it.

I think you are creating long-term confusion in order to save yourself a
little bit of editing work.  I don't object to having a combined macro
but it shouldn't be called $(libpq).  Maybe $(libpq_plus_support)
or something like that ... or even libpq_plus_libpgport ...

Also think about whether the hack in Makefile.global to add PTHREAD_LIBS
to $(libpq) ought to add them to $(libpq_plus_support) instead.  I'm
not sure about that one ... it might be that you cannot link libpq
successfully without PTHREAD_LIBS in the cases where the hack fires.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Josh BerkusDate: 2005-03-25 03:19:00
Subject: Re: [PATCHES] Approximate count(*)
Previous:From: Bruce MomjianDate: 2005-03-25 02:57:54
Subject: Re: Makefile breakage

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group