Skip site navigation (1) Skip section navigation (2)

Re: PL/Python patch for Universal Newline Support

From: Neil Conway <neilc(at)samurai(dot)com>
To: Michael Fuhr <mike(at)fuhr(dot)org>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: PL/Python patch for Universal Newline Support
Date: 2005-03-20 23:28:28
Message-ID: 423E071C.4010901@samurai.com (view raw or flat)
Thread:
Lists: pgsql-patches
Michael Fuhr wrote:
> Should the PL/Python documentation mention this behavior?

Isn't this the behavior the user would expect? If so, I guess it's okay 
not to document it.

> How should I submit regression tests?

Yes, please.

> *** src/pl/plpython/plpython.c	17 Dec 2004 02:14:48 -0000	1.58
> --- src/pl/plpython/plpython.c	19 Mar 2005 04:29:55 -0000
> ***************
> *** 1206,1215 ****
>   
>   	while (*sp != '\0')
>   	{
> ! 		if (*sp == '\n')
>   		{
> ! 			*mp++ = *sp++;
>   			*mp++ = '\t';
>   		}
>   		else
>   			*mp++ = *sp++;
> --- 1206,1219 ----
>   
>   	while (*sp != '\0')
>   	{
> ! 		if (*sp == '\r' && *(sp + 1) == '\n')
> ! 			sp++;
> ! 
> ! 		if (*sp == '\n' || *sp == '\r')
>   		{
> ! 			*mp++ = '\n';
>   			*mp++ = '\t';
> + 			sp++;
>   		}
>   		else
>   			*mp++ = *sp++;

Does this work for "\r\n" embedded in string literals?

-Neil

In response to

Responses

pgsql-patches by date

Next:From: Neil ConwayDate: 2005-03-20 23:40:49
Subject: Re: HeapTupleSatisfiesUpdate result as enum
Previous:From: Neil ConwayDate: 2005-03-20 23:08:59
Subject: Re: [patch 0/6] pgcrypto update

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group