Skip site navigation (1) Skip section navigation (2)

Re: [pgsql-hackers-win32] snprintf causes regression tests

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Nicolai Tufar <ntufar(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Magnus Hagander <mha(at)sollentuna(dot)net>,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>,PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests
Date: 2005-03-20 18:23:58
Message-ID: 423DBFBE.3050809@dunslane.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-hackers-win32pgsql-patches
After some further digging, I think we have 3 problems.

1. On Windows gettext wants to hijack printf and friends, as below. This
strikes me as rather unfriendly behaviour by a library header file.
Anyway, mercifully libintl.h is included in our source in exactly one
spot, so I think the thing to do for this problem is a) undo that
hijacking and b) make sure any hijacking we want to do occurs after the
point where that file in included (in c.h). This causes most of the
noise, but is probably harmless, since our hijacking does in fact win
out. We need to fix the arnings, though.

2. We have multiple #defines for snprintf and vsnprintf (in port.h and
win32.h).

3. ecpg wants to use our pg*printf routines (because USE_SNPRINTF is
defined) but doesn't know where to find them.

what a mess :-(

cheers

andrew


Bruce Momjian wrote:

>Thanks to Andrew Dunstan, I found the cause of these link errors. 
>Andrew found this in libintl:
>	
>	#undef snprintf
>	#define snprintf libintl_snprintf
>	extern int snprintf (char *, size_t, const char *, ...);
>
>What is happening is that we do:
>
>	#define snprintf        pg_snprintf
>
>and then libintl.h (?) does:
>
>	#define snprintf libintl_snprintf
>
>so the effect is:
>
>	#define pg_snprintf libintl_snprintf
>
>In fact, in this example, the system complains about a missing X3 symbol:
>
>	#define X1 X2
>	#define X2 X3
>	
>	int
>	main(int argc, char *argv[])
>	{
>	        X1;
>	}
>
>so the effet of the defines is:
>
>	#define X1 X3
>
>Anyway, the reason ecpg is failing is that it is the only client-side
>program that doesn't use libintl for internationalization.  It is on our
>TODO list to do that, but it hasn't been done yet.
>
>However, only Win32 is seeing this failure, and only when configure
>--enable-nls.  I think this is because only Win32 does the redefine of
>snprint and friends.
>
>Comments?
>	
>---------------------------------------------------------------------------
>
>Nicolai Tufar wrote:
>  
>
>>On Wed, 16 Mar 2005 01:00:21 -0500 (EST), Bruce Momjian
>><pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
>>    
>>
>>>I have applied a modified version of your patch, attached.
>>>      
>>>
>>I am so sorry, I sent untested patch again.  Thank you very
>>much for patience in fixing it. The patch looks perfectly
>>fine and works under Solaris. 
>>
>>Under win32 I am still struggling with build environment.
>>In many directories link fails with "undefined reference to
>>`pg_snprintf'" in other it fails with  "undefined reference to
>>`_imp__libintl_sprintf'". In yet another directory it fails with
>>both, like in src/interfaces/ecpg/pgtypeslib:
>>
>>dlltool --export-all  --output-def pgtypes.def numeric.o datetime.o
>>common.o dt_common.o timestamp.o interval.o pgstrcasecmp.o
>>dllwrap  -o libpgtypes.dll --dllname libpgtypes.dll  --def pgtypes.def
>>numeric.o datetime.o common.o dt_common.o timestamp.o interval.o
>>pgstrcasecmp.o  -L../../../../src/port -lm
>>numeric.o(.text+0x19ea):numeric.c: undefined reference to
>>`_imp__libintl_sprintf'
>>datetime.o(.text+0x476):datetime.c: undefined reference to `pg_snprintf'
>>common.o(.text+0x1cd):common.c: undefined reference to `pg_snprintf'
>>common.o(.text+0x251):common.c: undefined reference to `pg_snprintf'
>>dt_common.o(.text+0x538):dt_common.c: undefined reference to
>>`_imp__libintl_sprintf'
>>dt_common.o(.text+0x553):dt_common.c: undefined reference to
>>`_imp__libintl_sprintf'
>>dt_common.o(.text+0x597):dt_common.c: undefined reference to
>>`_imp__libintl_sprintf'
>>dt_common.o(.text+0x5d5):dt_common.c: undefined reference to
>>`_imp__libintl_sprintf'
>>dt_common.o(.text+0x628):dt_common.c: undefined reference to
>>`_imp__libintl_sprintf'
>>dt_common.o(.text+0x7e8):dt_common.c: more undefined references to
>>`_imp__libintl_sprintf' follow
>>c:\MinGW\bin\dllwrap.exe: c:\MinGW\bin\gcc exited with status 1
>>make: *** [libpgtypes.a] Error 1
>>
>>Could someone with a better grasp of configure and 
>>win32 environment check it? Aparently no one regularily 
>>compiles source code under win32 during development cycle
>>these days.
>>
>>
>>Best regards,
>>Nicolai
>>
>>---------------------------(end of broadcast)---------------------------
>>TIP 4: Don't 'kill -9' the postmaster
>>
>>    
>>
>
>  
>


In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2005-03-20 18:24:16
Subject: Re: what to do with backend flowchart
Previous:From: Marc G. FournierDate: 2005-03-20 18:07:40
Subject: Re: Moving a project from gborg to pgfoundry?

pgsql-patches by date

Next:From: Magnus HaganderDate: 2005-03-20 18:37:13
Subject: Re: explain analyze timings
Previous:From: Tom LaneDate: 2005-03-20 17:42:58
Subject: Re: explain analyze timings

pgsql-hackers-win32 by date

Next:From: Magnus HaganderDate: 2005-03-20 18:37:13
Subject: Re: explain analyze timings
Previous:From: Tom LaneDate: 2005-03-20 17:42:58
Subject: Re: explain analyze timings

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group