Skip site navigation (1) Skip section navigation (2)

Re: contrib/pg_buffercache

From: Mark Kirkwood <markir(at)paradise(dot)net(dot)nz>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>,pgsql-patches(at)postgresql(dot)org
Subject: Re: contrib/pg_buffercache
Date: 2005-03-17 00:47:20
Message-ID: 4238D398.1080708@paradise.net.nz (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Andrew Dunstan wrote:
> It fixes the build error on Windows - haven't tried because i don't have
> time, but I know it won't work on Cygwin, because WIN32 isn't (usually)
> defined on Cygwin - see previous almost endless discussions.
> 

Yes - I recall that discussion a while ago.

This patch should sort the issue.

One question, should I be using defined(__MINGW32__) as opposed to
defined(WIN32)? I figured I didn't as in this case it is not necessary
to distinguish between native and cygwin.

regards

Mark





Attachment: pg_buffercache_pages.h.diff
Description: text/plain (472 bytes)

In response to

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2005-03-17 01:20:10
Subject: Re: contrib/pg_buffercache
Previous:From: Satoshi NagayasuDate: 2005-03-17 00:37:33
Subject: Re: read-only database

pgsql-patches by date

Next:From: Andrew DunstanDate: 2005-03-17 01:20:10
Subject: Re: contrib/pg_buffercache
Previous:From: Satoshi NagayasuDate: 2005-03-17 00:37:33
Subject: Re: read-only database

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group